Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Complete Crate Re-write #160

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Conversation

makspll
Copy link
Owner

@makspll makspll commented Dec 3, 2024

No description provided.

@makspll makspll changed the title Feature/bevy system refactor Plugin System Refactor Dec 3, 2024
@makspll
Copy link
Owner Author

makspll commented Dec 7, 2024

I now have most functionality back, I think I just need to reimplement metamethods for glam types, I.e. add sub mul

@shanecelis
Copy link
Contributor

We wait with bated breath. God speed. :D

@makspll
Copy link
Owner Author

makspll commented Dec 29, 2024

We wait with bated breath. God speed. :D

It's soooooo close, I can't wait to get this out :D

@gfxenjoyer
Copy link

Hi. I've been playing around with this branch and tried to build the coroutines_lua example with luau and got these two errors.

error[E0308]: mismatched types
  --> crates\languages\bevy_mod_scripting_lua\src\bindings\script_value.rs:37:55
   |
37 |             Value::Integer(i) => ScriptValue::Integer(i),
   |                                  -------------------- ^ expected `i64`, found `i32`
   |                                  |
   |                                  arguments to this enum variant are incorrect
   |
error[E0308]: mismatched types
  --> crates\languages\bevy_mod_scripting_lua\src\bindings\script_value.rs:76:55
   |
76 |             ScriptValue::Integer(i) => Value::Integer(i),
   |                                        -------------- ^ expected `i32`, found `i64`
   |                                        |
   |                                        arguments to this enum variant are incorrect
   |

Amazing work so far, and I am looking forward to this being merged!

@makspll
Copy link
Owner Author

makspll commented Dec 31, 2024

Okay that's all the functionality complete, I still need to fix up tests, and clean up / make docs but I will move this into staging

@makspll makspll changed the base branch from main to staging December 31, 2024 18:46
@makspll makspll changed the title feat: Plugin System Refactor feat: Complete Crate Re-write Dec 31, 2024
@makspll makspll merged commit dce02e8 into staging Dec 31, 2024
13 of 17 checks passed
@makspll makspll deleted the feature/bevy-system-refactor branch December 31, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants