Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[route] 지도에 이동경로 페이지 값 연결 #97

Merged
merged 3 commits into from
Dec 5, 2023
Merged

[route] 지도에 이동경로 페이지 값 연결 #97

merged 3 commits into from
Dec 5, 2023

Conversation

dev0leee
Copy link
Member

@dev0leee dev0leee commented Dec 4, 2023 •
edited
Loading

🚩 이슈 번호

📝 작업 내용

  • 이동경로 상세 조회 api 호출을 위해 임시로 하드코딩 해뒀던 부분을 -> search 페이지의 recoil 값으로 변경
  • 와중에 필요한 type import 및 수정

스크린샷 2023-12-04 오후 8 16 17

📣 리뷰 요청사항/알릴사항/질문

  • 이전 까를로스 pr 에 src/type/search.ts 같이 수정한 부분 있던데, merge 되면 pull 받아서 이 부분 수정해서 현재 pr에 commit 올리겠습니다.
  • 현재 버스면 파랑색, 지하철이면 노랑색으로 표시되고 있습니다. 지하철 호선에 따른 색상은 추후 보완하겠습니다.

@dev0leee dev0leee added the 🚀 feat 새로운 기능 추가 label Dec 4, 2023
@dev0leee dev0leee self-assigned this Dec 4, 2023
@vercel Vercel
Copy link

vercel bot commented Dec 4, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
makchata ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2023 1:44pm

dlsxody1
dlsxody1 approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@dlsxody1 dlsxody1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

wlsud801
wlsud801 approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@wlsud801 wlsud801 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

녕녕 pull 받아주세용!

@dev0leee dev0leee merged commit 786aebd into main Dec 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlsud801 wlsud801 wlsud801 approved these changes

@dlsxody1 dlsxody1 dlsxody1 approved these changes

Assignees

@dev0leee dev0leee

Labels
🚀 feat 새로운 기능 추가
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[route] 한눈에보기 데모수정
3 participants
@dev0leee @dlsxody1 @wlsud801