Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CA rather than the server cert in patching webhook #1863

Open
wants to merge 2 commits into
base: maistra-2.6
Choose a base branch
from

Conversation

nrfox
Copy link
Contributor

@nrfox nrfox commented Jan 30, 2025

When running the istio-operator with a 3.0 istiod, both will try to patch the validator webhook's caBundle. This isn't a problem if both try to patch the same bundle but with the istiod-tls secret present, the 2.6 operator will actually patch the istiod server cert tls.crt rather than the CA cert ca.crt. This patches changes the operator to patch the CA cert ca.crt.

When running the istio-operator with a 3.0 istiod, both will try to patch the validator webhook's caBundle. This isn't a problem if both try to patch the same bundle but with the `istiod-tls` secret present, the 2.6 operator will actually patch the istiod server cert `tls.crt` rather than the CA cert `ca.crt`. This patches changes the operator to patch the CA cert `ca.crt`.
Copy link

openshift-ci bot commented Jan 30, 2025

Hi @nrfox. Thanks for your PR.

I'm waiting for a maistra member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nrfox nrfox marked this pull request as ready for review January 31, 2025 15:47
@nrfox
Copy link
Contributor Author

nrfox commented Jan 31, 2025

/do-not-merge

@nrfox
Copy link
Contributor Author

nrfox commented Jan 31, 2025

/hold

@nrfox
Copy link
Contributor Author

nrfox commented Feb 4, 2025

@FilipB here's the maistra-test-tool test for this: maistra/maistra-test-tool#773. Covers ClusterWide mode but not MultiTenant yet.

@FilipB
Copy link
Contributor

FilipB commented Feb 4, 2025

/test push-images

Copy link

openshift-ci bot commented Feb 4, 2025

@nrfox: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/push-images b89eed3 link true /test push-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@FilipB
Copy link
Contributor

FilipB commented Feb 4, 2025

We had some failures when running MTT against this PR. Checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants