-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use CA rather than the server cert in patching webhook #1863
base: maistra-2.6
Are you sure you want to change the base?
Conversation
When running the istio-operator with a 3.0 istiod, both will try to patch the validator webhook's caBundle. This isn't a problem if both try to patch the same bundle but with the `istiod-tls` secret present, the 2.6 operator will actually patch the istiod server cert `tls.crt` rather than the CA cert `ca.crt`. This patches changes the operator to patch the CA cert `ca.crt`.
Hi @nrfox. Thanks for your PR. I'm waiting for a maistra member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/do-not-merge |
/hold |
@FilipB here's the maistra-test-tool test for this: maistra/maistra-test-tool#773. Covers |
/test push-images |
@nrfox: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
We had some failures when running MTT against this PR. Checking. |
When running the istio-operator with a 3.0 istiod, both will try to patch the validator webhook's caBundle. This isn't a problem if both try to patch the same bundle but with the
istiod-tls
secret present, the 2.6 operator will actually patch the istiod server certtls.crt
rather than the CA certca.crt
. This patches changes the operator to patch the CA certca.crt
.