Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate semver PR label check into its own workflow #36

Merged
merged 1 commit into from
Dec 31, 2023
Merged

Conversation

jcouball
Copy link
Member

@jcouball jcouball commented Dec 31, 2023

Separate semver PR label check into its own workflow

Putting this into the Continuous Integration workflow caused the workflow to trigger two times when a PR is created because creating the PR and applying the first label seem to be BOTH triggered. This was causing 9 build jobs to run twice unnecessarily.

This change separates out the semver PR label check into its own workflow. This semver PR label check workflow is still triggered twice when a PR is created with an initial label. At least the Continuous Integration workflow is not triggered twice.

@jcouball jcouball added the internal-change The PR includes changes that are NOT user-facing and will NOT require a release label Dec 31, 2023
Putting this into the Continuous Integration workflow caused the workflow to trigger two times when a PR is created because creating the PR and applying the first label seem to be both triggered. This was causing 9 build jobs to run twice unnecessarily.

This change separates out the semver PR label check into its own workflow. This semver PR label check workflow is still triggered twice when a PR is created with an initial label. At least the Continuous Integration workflow is not triggered twice.
Copy link

codeclimate bot commented Dec 31, 2023

Code Climate has analyzed commit f675c88 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@jcouball jcouball merged commit e11f03e into main Dec 31, 2023
14 checks passed
@jcouball jcouball deleted the workflow_fix branch December 31, 2023 16:33
@jcouball jcouball mentioned this pull request Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal-change The PR includes changes that are NOT user-facing and will NOT require a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant