Fix unmarshal null values for non-pointer fields #411
Merged
+41
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#407 fixed the issue where an explicit null field did not reset the value, but a regression was introduced where previously it skipped any null values for non-pointer fields, that now returns an error.
This PR adds a
IsNull()
check before each unmarshal and the result is the same behavior as I see with stdlib now.eg. stdlib ignores any null values for non-pointer fields: https://goplay.tools/snippet/dEJi7819RKc
The updated unit test also validates this behavior.
Without this change, the updated test fails to unmarshal: