Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mailhog is primarily a debugging tool we want to validate the correctness of bcc and cc as well.
See #98, #261
Possible solutions
Duplicating emails won't help debugging and may make it even worse. So we went for the "show in preview" option.
Implementation
Bcc should not be contained in the mail source. Otherwise it wouldn't be a "blind" copy as the recipients could see the blind copy recipients. Every recipient (to, cc, bcc) should be part of the
RCPT
though. So from my understanding and the insight of this Mailtrap article bcc should beallRecipients - to - cc
. This calculated bcc is what I implemented and added to theMessage
struct.On the GUI side I decided to follow the suggestion of
jankonas and show cc and bcc alongside with "from" and "subject". Cc and bcc are only shown if they have content. This way the user can easily debug who should've received the mail.