Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multilevel multipart HTML preview #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

synchrone
Copy link

go depth-first while searching for a matching content-type in multi-level multipart emails (e.g html+inline images as multipart/related + attached files)

Fixes mailhog/MailHog#238

…evel multipart emails (e.g html+inline images as multipart/related + attached files)
@andreasciamanna
Copy link

Any chance this will get merged?

@eugen-korentsov
Copy link

eugen-korentsov commented Sep 6, 2022

Any chance this will get merged?
@gedge @tyndyll @ian-kent

@synchrone
Copy link
Author

i guess we should summon @ian-kent @gedge or @tyndyll. Guys, this is a pretty small change, but fixes a pesky bug that makes the UI unusable for a whole class of messages. Please take 10 minutes to review?

@synchrone
Copy link
Author

oh, i didn't notice the previous commenter edited their message to add mentions. Sorry for double positng!

@isinitskaya-casafari
Copy link

guys, we really need it

@andreasciamanna
Copy link

I couldn't wait for a fix and I don't have the skills nor the time to contribute.
I switched to smtp4dev.
It just works.

@eugen-korentsov
Copy link

@andreasciamanna thank you, I've tested smt4dev also and can confirm that it just works!

synchrone added a commit to synchrone/MailHog-UI that referenced this pull request Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MailHog sending mail attachment problem
4 participants