Add retry mechanism for MongoDB connection #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add retry mechanism for MongoDB connection
This was referenced Jul 19, 2020
|
does this supercede #16 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a configurable retry mechanism when connecting to a MongoDB instance.
Motivation
When running MailHog with MongoDB In a containerized environment, it is likely that starting the MongoDB service needs longer than starting MailHog. In this case, MailHog does a fallback to its in-memory storage without further notification. This is probably not what you want when running a MongoDB.
Description
This PR adds three new configuration options:
MongoRetriesMongoRetryIntervalInMemoryFallbackWhen having configured MongoDB, MailHog will execute
MongoRetriesattempts for a successful connection. Between each attempts it will wait forMongoRetryIntervalseconds. If the connection is not successful, it will either exit (InMemoryFallback = false) or use in-memory storage (InMemoryFallback = true).