DSU-1393 Run unit tests on CI #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Dec 20, 2022
| for i := range starts { | ||
| err := starts[i].err | ||
| want := starts[i].want | ||
| testFormatCompleteCompare(t, i, err, "%+v", want, false) |
There was a problem hiding this comment.
Curious about this one: any context on why we do for i := range starts instead of for _, start := range starts {? More of a stylistic item but I've leaned towards the explicit form where we show that the range clause is actually 2 values
There was a problem hiding this comment.
I've just renamed the variable based on https://dave.cheney.net/practical-go/presentations/qcon-china.html#_use_a_consistent_naming_style
Also, it can't be for _, start := range starts { cause we need to pass index to the testFormatCompleteCompare().
From a performance perspective, index access is preferable for the slice of big objects - https://go-critic.com/overview.html#rangeValCopy-ref
Baliedge
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://mailgun.atlassian.net/browse/DSU-1393
Found issues: