chore: increase quotes fetch sample to 10
#2665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickvandijke
commented
Jan 24, 2025
ant-networking/src/lib.rs
Outdated
| @@ -1075,6 +1075,7 @@ impl Network { | |||
| &self, | |||
| key: &NetworkAddress, | |||
| client: bool, | |||
| expanded_close_group_size: Option<usize>, | |||
There was a problem hiding this comment.
I did not want unintentional side effects on the node side for increasing the close group size here, thus an option.
There was a problem hiding this comment.
as long as the value is under KValue(20), it's still the local calculation.
just result in extra small messagings to be exchanged.
I don't think it needs to be an option ? as we cann't set it as None anyway ?
mickvandijke
force-pushed
the
chore-increase-quotes-sample-size-to-10
branch
from
6fa416f to
817ac02
Compare
maqi
requested changes
Jan 24, 2025
ant-networking/src/lib.rs
Outdated
| @@ -1075,6 +1075,7 @@ impl Network { | |||
| &self, | |||
| key: &NetworkAddress, | |||
| client: bool, | |||
| expanded_close_group_size: Option<usize>, | |||
There was a problem hiding this comment.
as long as the value is under KValue(20), it's still the local calculation.
just result in extra small messagings to be exchanged.
I don't think it needs to be an option ? as we cann't set it as None anyway ?
mickvandijke
force-pushed
the
chore-increase-quotes-sample-size-to-10
branch
from
817ac02 to
508bd27
Compare
maqi
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.