Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LTC] Implement Gandalf of the Secret Fire #13265

Merged

Conversation

PurpleCrowbar
Copy link
Member

Encountering an issue with giving the exiled card Suspend. Have verified with breakpoints / game.informPlayers that the if statement at L121 is consistently evaluating as true, so game.addEffect(new GainSuspendEffect(mor), source); is being called, but the card in-game does not have suspend. This implementation is based off other suspend-related effects so not sure what I'm missing here.

@PurpleCrowbar
Copy link
Member Author

[[Gandalf of the Secret Fire]]

@github-actions github-actions bot added the cards label Jan 28, 2025
Copy link

Gandalf of the Secret Fire - (Gatherer) (Scryfall) (EDHREC)

{1}{U}{R}{W}
Legendary Creature — Avatar Wizard
3/4
Whenever you cast an instant or sorcery spell from your hand during an opponent's turn, exile that card with three time counters on it instead of putting it into your graveyard as it resolves. Then if the exiled card doesn't have suspend, it gains suspend. (At the beginning of your upkeep, remove a time counter. When the last is removed, you may play it without paying its mana cost.)

@padfoothelix
Copy link
Contributor

This implementation seems to be based on that of Feather, the Redeemed.
It will be affected by the same bugs reported in issue #13227.
I have issued a pull request (#13226) to fix these but it is still pending.

I am not sure how these interact with the difficulty you mention.

@JayDi85
Copy link
Member

JayDi85 commented Jan 28, 2025

Try to find mor of the card after exile (in exile zone), not a spell. Exile change zone and card’s zcc, so old mor is outdated after that. Alternative — use new mor with +1 zcc param.

@PurpleCrowbar
Copy link
Member Author

Try to find mor of the card after exile (in exile zone), not a spell. Exile change zone and card’s zcc, so old mor is outdated after that. Alternative — use new mor with +1 zcc param.

Yep, just needed to get the card instead of the spell. All working now - will merge this after CI passes

@PurpleCrowbar PurpleCrowbar changed the title [LTC][WIP] Implement Gandalf of the Secret Fire [LTC] Implement Gandalf of the Secret Fire Jan 30, 2025
@PurpleCrowbar PurpleCrowbar merged commit edf5705 into magefree:master Jan 30, 2025
2 checks passed
@PurpleCrowbar PurpleCrowbar deleted the gandalf-of-the-secret-fire branch January 30, 2025 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants