Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mage.Server sqlite-jdbc from 3.32.3.2 to 3.46.1.3 #12993

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

paasar
Copy link
Contributor

@paasar paasar commented Oct 12, 2024

This allows the service to be run on Apple silicon (M1, M2, M3).

This allows the service to be run on Apple silicon (M1, M2, M3).
@xenohedron
Copy link
Contributor

@JayDi85 can you please explain what's blocking this dependency upgrade?

@JayDi85
Copy link
Member

JayDi85 commented Oct 12, 2024

Need workable test with existing db file to confirm a workable state by unit tests, see h2 tests example (in old days h2 lib upgrade break whole db on public server cause unit tests didn’t test real data, e.g. miss migration tests).

It was last time. After some reviews I want to remove whole db stats part from a project as outdated and useless. It must be implemented another way, without binary/protobuf data saving in db. Also public stats db affected by sqlite file size limitation and can break server on too big sizes (de server catch such bugs few times on stats db size > 1 GB).

So I will remove all that code soon.

@xenohedron
Copy link
Contributor

Makes sense about removing that old stats db altogether. Does that mean this dependency could be removed entirely?

@JayDi85
Copy link
Member

JayDi85 commented Oct 12, 2024

Yes, all sqlite databases must be removed with that dependency. User rating calculates in real time (after match finish) and do not depends on recorded game stats (records db). So all must be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants