Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update painlands to use better mana abilities #12871

Merged

Conversation

Dunkoro
Copy link
Contributor

@Dunkoro Dunkoro commented Sep 14, 2024

This will make tapping painlands less... of a pain.

@github-actions github-actions bot added the cards label Sep 14, 2024
@Dunkoro Dunkoro changed the title Optimise imports Update painlands to use better mana abilities Sep 14, 2024
@JayDi85
Copy link
Member

JayDi85 commented Sep 14, 2024

Need more details on your changes for a user side: before and after.

@Dunkoro
Copy link
Contributor Author

Dunkoro commented Sep 14, 2024

This is the relevant issue thread.
#12661

@Grath Grath self-requested a review September 15, 2024 02:53
Copy link
Contributor

@Grath Grath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will make painlands stop prompting users when tapping them. This updates the antiquated implementation of painlands to follow the modern syntax used in the Talisman cycle.

@xenohedron xenohedron merged commit 7bf02e5 into magefree:master Sep 15, 2024
2 checks passed
@Dunkoro Dunkoro deleted the update_painlands_for_simpler_tapping branch September 16, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants