Update Rage Extractor's Phyrexian mana symbol letter code #12612
Conversation
| case "P": | ||
| symbol = "p"; | ||
| case "H": | ||
| symbol = "h"; |
There was a problem hiding this comment.
is this actually a valid symbol in gatherer now?
There was a problem hiding this comment.
A couple people here said we should be good to do this before wizards gets this symbol updated. As of now, {P} leads to the pawprint symbol, and {H} is not a valid link.
There was a problem hiding this comment.
Yeah, this change doesn't depend on gatherer because scryfall has it, but if the gatherer part isn't working, then best to add a comment here
| @@ -23,7 +23,7 @@ | |||
| */ | |||
| public final class RageExtractor extends CardImpl { | |||
|
|
|||
| private static final FilterSpell filter = new FilterSpell("a spell with {P} in its mana cost"); | |||
| private static final FilterSpell filter = new FilterSpell("a spell with {H} (<i>a phyrexian mana symbol</i>) in its mana cost"); | |||
There was a problem hiding this comment.
I see the merit in this, but I'm not convinced we should be adding reminder text that doesn't exist. At least put the parentheses inside the italics
There was a problem hiding this comment.
Maybe i'll take it out--not worth tracking so closely for one card i suppose
#11853
See this comment for more info