Implement Alania, Divergent Storm #12601
Conversation
|
Did strict oracle text checks get turned back on? |
| } | ||
| } | ||
|
|
||
| // Based on FirstSpellCastThisTurnWatcher |
There was a problem hiding this comment.
well the reference watcher is bugged, because it's checking id without zcc, needs to save MageObjectReference instead.
don't worry about the verify failure, it's a rarity error in BLC, scryfall fixed it upstream, we need to update it to match |
|
Is there a way to get a MageObjectReference pointing to the stack spell that became the permanent whose UUID you have now? Or am i going about this wrong? Right now i'm trying to get this in order to pass it into the watcher's validation function, so it can check it against the first saved Otter cast. |
|
Yeah, MageObjectReference has a constructor that takes an offset, so either +1 or -1 (depending on how you do it) will match spell to the permanent it becomes. |
|
That doesn't seem to hit a match with the recorded MOR of the first Otter cast. My watch function records like so: Spell spell = (Spell) game.getObject(event.getTargetId());
if (spell == null) {
return;
}
if (!game.isSimulation()){
logger.info("Spell cast: " + spell.getName());
logger.info("Spell ID: " + spell.getId());
}
UUID spellControllerID = spell.getControllerId();
MageObjectReference spellMOR = new MageObjectReference(spell, game);
if (spell.getCardType(game).contains(CardType.INSTANT) &&
!playerFirstInstantCast.containsKey(spellControllerID)) {
playerFirstInstantCast.put(spellControllerID, spellMOR);
}
if (spell.getCardType(game).contains(CardType.SORCERY) &&
!playerFirstSorceryCast.containsKey(spellControllerID)) {
playerFirstSorceryCast.put(spellControllerID, spellMOR);
}
if (spell.getSubtype(game).contains(SubType.OTTER)){
if (!game.isSimulation()){
logger.info("Is Otter!");
}
if (!playerFirstOtterCast.containsKey(spellControllerID)) {
playerFirstOtterCast.put(spellControllerID, spellMOR);
if (!game.isSimulation()){
logger.info("Is First");
}
} else if (!playerSecondOtterCast.containsKey(spellControllerID)) {
playerSecondOtterCast.put(spellControllerID, spellMOR);
if (!game.isSimulation()){
logger.info("Is Second");
}
}
}The apply() function then grabs the necessary info to pass into the validator: Spell spell = (Spell) source.getEffects().get(0).getValue("spellCast");
if (spell == null) {
return false;
}
Permanent sourcePermanent = source.getSourcePermanentOrLKI(game);
if (!game.isSimulation()){
logger.info("sourcePermanent: " + sourcePermanent);
logger.info("name: " + sourcePermanent.getName());
}
// Get source permanent MOR from when it was on the stack
MageObjectReference sourceSpellMOR = new MageObjectReference(sourcePermanent, game, -1); //This in theory should be the spell that became the source permanent
AlaniaDivergentStormWatcher watcher = game.getState().getWatcher(AlaniaDivergentStormWatcher.class);
UUID spellControllerID = spell.getControllerId();
MageObjectReference spellMOR = new MageObjectReference(spell, game);
return watcher.spellIsFirstISOCast(spellControllerID, spellMOR, sourceSpellMOR, game);which is: public boolean spellIsFirstISOCast(UUID controllerID, MageObjectReference spell, MageObjectReference AlaniaMOR, Game game) {
MageObjectReference firstOtterMOR = playerFirstOtterCast.get(controllerID);
if (!game.isSimulation()){
logger.info("firstOtterMOR: " + firstOtterMOR.getSourceId());
logger.info("spell: " + spell.getSourceId());
logger.info("AlaniaMOR: " + AlaniaMOR.getSourceId());
// logger.info(AlaniaMOR.getCard(game).getName());
}
if (firstOtterMOR != null && firstOtterMOR.equals(AlaniaMOR)) {
firstOtterMOR = playerSecondOtterCast.get(controllerID);
if (!game.isSimulation()){
logger.info("oops, that was Alania. ACTUAL firstOtterMOR: " + firstOtterMOR);
}
}
return spell.equals(playerFirstInstantCast.get(controllerID)) ||
spell.equals(playerFirstSorceryCast.get(controllerID)) ||
(spell.equals(firstOtterMOR));
}Casting Alania and a second otter yields: |
|
Yeah, i'm stumped for this. It looks like spells entering the battlefield get a new UUID from what it had on the stack, so making a MOR of a permanent with an offset of -1 doesnt net you a MOR that is equivalent to the MOR of the spell that was cast to make that permanent. How is this supposed to work? |
|
I think i cracked it. Turns out the UUID of a spell on a stack is derived from its SpellAbility, not the Card that was cast. |
| this.getTargets().clearChosen(); | ||
| paid = false; | ||
| if (this.getTargets().choose(Outcome.DrawCard, controllerId, source.getSourceId(), source, game)) { | ||
| Player opponent = game.getPlayer(this.getTargets().get(0).getTargets().get(0)); |
There was a problem hiding this comment.
can't you just use this.getTargets().getFirstTarget()?
| if (opponent == null || !opponent.canRespond()){ | ||
| return false; | ||
| } | ||
| paid = opponent.drawCards(1, source, game) != 0; |
There was a problem hiding this comment.
a little weird to be using != 0 rather than > 0
| MageObjectReference spellMOR = new MageObjectReference(spell, game); | ||
| if (spell.getCardType(game).contains(CardType.INSTANT) && | ||
| !playerFirstInstantCast.containsKey(spellControllerID)) { | ||
| playerFirstInstantCast.put(spellControllerID, spellMOR); |
There was a problem hiding this comment.
putIfAbsent might be simpler syntax
#11853
Assumption made here:
"if it's the first instant spell, the first sorcery spell, or the first Otter spell other than Alania you've cast this turn" means that this will trigger up to three times per turn, once for each spell of those three criteria, assuming that none of those three spells fits both of those criteria.
Question: How can I cause the
AlaniaDivergentStormWatchernot count the cast of Alania, Divergent Storm, like in the oracle text? I assume this would happen by having the watcher check to see if theSPELL_CASTevent belongs to a Spell that owns this instance of the watcher, but its possible that there's a better strategy.Write test: