AWS MageAI template meant for adding MageAI to existing AWS infrastructure #37
Conversation
|
Thank you @Ladvien for the PR! Will review it today. |
| variable "allowed_cidr_blocks" { | ||
| type = list(string) | ||
| description = "List of CIDR blocks to allow access to the ECS service" | ||
| } |
There was a problem hiding this comment.
nit: add empty line at the end of the file
| @@ -0,0 +1,3 @@ | |||
| output "mage_ai_lb_dns_name" { | |||
| value = "MageAI URL: ${aws_alb.application_load_balancer.dns_name}" | |||
| } | |||
| } | ||
|
|
||
|
|
||
| locals { |
There was a problem hiding this comment.
I saw you removed the use of "env_vars.json" file. Do you have any particular reason for that?
There was a problem hiding this comment.
I did. But none I'm attached to. Adding it back.
|
|
||
| ## Pre-Deployment | ||
| Before deployment, you must have the following installed: | ||
| * [Terragrunt](https://terragrunt.gruntwork.io/) |
There was a problem hiding this comment.
It can also be run without Terragrunt, right?
There was a problem hiding this comment.
It can now I've added back the env_vars.json.
|
Hi @Ladvien , just want to make sure you didn't miss my comments. Would you like to address the comments so that we can get the PR merged? |
|
Hey @wangxiaoyou1993, it’s on my list. But no time yet. |
…sk_memory, and docker_image.
|
Hey @wangxiaoyou1993, sincere apologies for taking a bit of time to respond. Work got busy. Just let me know what else you'd like done and I'll try not to take another month to get to it. 😅 |
Summary
I've modified the
mage-ai-terraform-templates/awsmodule to do the following:postgrescontrol DBterragrunt.hcl(inputs) fileTests
It works on my AWS? 😬
cc:
@wangxiaoyou1993, here's the PR I mentioned. Feel free to tell me what you'd like to see different.