Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://developer.apple.com/documentation/servicemanagement?language=objc
Generated PR: madsmtm/objc2-generated#9
A note: When running
header-translator
, I was getting a panic at:objc2/crates/header-translator/src/main.rs
Line 280 in 5391a0d
I logged the filename and found that
header-translator
is trying to get theServiceManagement.h
file, which didn't exist inlibrary.files
.The reason why it's trying to get
ServiceManagement.h
is because unlike most "umbrella" files in frameworks, theServiceManagement.h
file has a fewconst CFStringRef
declarations in them.This is perhaps also reflected in
ServiceManagement
's modulemap, where the umbrella declaration is:Instead of something found in all other
icrate
supported Frameworks:Since we need to skip all the declarations in
ServiceManagement.h
forCoreFoundation
reasons, a workaround is just to delay unwrapping the file unless we parsed usable statements, which is implemented in this PRA question: The "Service Management" framework in general is supported on earlier macOS versions than the
SMAppService
, so which versions should I put incrates/header-translator/translation-config.toml
? Also, whichunstable-frameworks-macos-*
should I put it under?