Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: RUST_LOG filtering #185

Merged
merged 5 commits into from
Nov 28, 2024
Merged

Refactor: RUST_LOG filtering #185

merged 5 commits into from
Nov 28, 2024

Conversation

heemankv
Copy link
Contributor

Filtering based on RUST_LOG stopped working after clap integration.
removed log_level from clap to get it to working again

@heemankv heemankv self-assigned this Nov 26, 2024
heemankv
heemankv commented Nov 26, 2024
View reviewed changes
Copy link
Contributor Author

@heemankv heemankv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self review done, looks good.

@coveralls
Copy link

coveralls commented Nov 26, 2024 •
edited
Loading

Coverage Status

coverage: 68.015% (-0.1%) from 68.127%
when pulling f9f4c9f on fix/rust_log_filtering
into 2ab2291 on main.

@heemankv heemankv requested review from ocdbytes and removed request for apoorvsadana November 26, 2024 15:25
@heemankv heemankv merged commit 4b0fce4 into main Nov 28, 2024
9 checks passed
@heemankv heemankv deleted the fix/rust_log_filtering branch November 28, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocdbytes ocdbytes ocdbytes approved these changes

@Mohiiit Mohiiit Mohiiit approved these changes

Assignees

@heemankv heemankv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@heemankv @coveralls @Mohiiit @ocdbytes