Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker file #776

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix docker file #776

wants to merge 1 commit into from

Conversation

abueide
Copy link

@abueide abueide commented Jul 9, 2021

Didn't understand what the original docker file was doing and couldn't get it to work, so I just made my own simplified version using ubuntu. Just making a pull request in case its useful, if not feel free to just close.

@SebMoore
Copy link
Contributor

SebMoore commented Jul 9, 2021

Look this is good, but let me try to explain what the original dockerfile was doing and why.
The original file uses Alpine Linux: this is a linux distro that is highly desirable for Docker images because it is fifty times smaller than the Ubuntu Docker image (it's only 4MB - crazy right?). The lines referring to "apk" are just installing packages - apk is alpine's package system (like apt for ubuntu/debian). The reason (I think) there is so many more of them is that Ubuntu has a bunch of packages installed by default, and packages like build-essential actually install many dependency packages. Thing is, only some of those dependencies are actually required - like g++. Hence, the dockerfile just chooses to install the bare minimum amount of packages to avoid becoming bloated.
Yes, if it doesn't work for you then that's a more serious problem - but I don't think the right approach is to move the whole thing to Ubuntu. I unfortunately don't have docker installed so I can't workshop any solutions to your problem, but yeah - if your dockerfile works then it works, and I appreciate you sharing it, but unfortunately I don't think it's the right approach.

@madMAx43v3r
Copy link
Owner

maybe a second Dockerfile then?

@SebMoore
Copy link
Contributor

SebMoore commented Jul 9, 2021

maybe a second Dockerfile then?

that sounds like a good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants