Add log timestamp #455
Open
Add log timestamp #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
there's a lot of whitespace changes unfortunately... |
|
Ah, my bad, VSCode auto-remove trailing whitespace on save... I'll revert the spaces. |
gurki
force-pushed
the
add-log-timestamp
branch
5 times, most recently
from
bbfa6bc to
5929588
Compare
madMAx43v3r
reviewed
Jun 16, 2021
| @@ -375,6 +375,16 @@ namespace Util { | |||
| } | |||
| } | |||
|
|
|||
| inline | |||
| std::string get_curr_datetime() | |||
There was a problem hiding this comment.
there's already a function for that, see get_date_string_ex()
There was a problem hiding this comment.
you can call that function inside this one
|
Maybe add a file option to this PR at the same time? It's fine and all with using | or >, >> but that breaks SIGINT options with ctrl+c. so you have to use |
|
yeah I would prefer the timestamps to be in a log file, not on the terminal |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds iso timestamps in front of relevant log messages to allow for more fine-grained benchmarking and monitoring.