Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAudio: update to 24.10 #26320

Merged
merged 2 commits into from
Oct 27, 2024
Merged

FAudio: update to 24.10 #26320

merged 2 commits into from
Oct 27, 2024

Conversation

barracuda156
Copy link
Contributor

Description

Update

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6.8
Xcode 3.2.6

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@reneeotten
Copy link
Contributor

@barracuda156 according to the CI this fails on macOS 15 and there is a Trac ticket - please take a look.

@barracuda156
Copy link
Contributor Author

@reneeotten I have opened an issue with upstream: FNA-XNA/FAudio#362
Closing this, I have no interest to work on macOS 15 myself.

@reneeotten
Copy link
Contributor

no need to close the PR. If it's the same issue as in the ticket there is a workaround that apparently works so you could just use that.
Thanks for opening an issue upstream; it this works elsewhere and only mot on macOS 15 right mow, we can still merge this - but not if you close the PR 😉

@kencu
Copy link
Contributor

kencu commented Oct 27, 2024

somehow seems to be building on macOS 15 for homebrew…

https://github.com/Homebrew/homebrew-core/blob/master/Formula/f/faudio.rb

@kencu
Copy link
Contributor

kencu commented Oct 27, 2024

ah, it’s the deployment target fix, as @reneeotten said.

you need to modify this:

https://github.com/barracuda156/powerpc-ports/blob/52cb1dbb0cd625f1f46d83e202e971a722dc4bcb/audio/FAudio/Portfile#L40

@barracuda156
Copy link
Contributor Author

@kencu Yeah, was just going to reply that perhaps same bug as on Sonoma.

@barracuda156 barracuda156 reopened this Oct 27, 2024
@kencu
Copy link
Contributor

kencu commented Oct 27, 2024

close your upstream issue, or at least modify it.

they set the deployment target in their build so don’t see this… macports strips it out with a patch, so we do.

(still needs fixing upstream, imho, somehow. but we break it.)

@kencu
Copy link
Contributor

kencu commented Oct 27, 2024

I guess we'll see if this issue is restricted to arm processors... it might be.

@kencu kencu merged commit 7f1bbfd into macports:master Oct 27, 2024
4 checks passed
@barracuda156 barracuda156 deleted the FAudio branch October 28, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants