Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbeaver-community: Update to 2024.2.3 and add all_arches variant. #26314

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JLindop
Copy link
Contributor

@JLindop JLindop commented Oct 26, 2024

Description

The all_arches variant requests distfiles for both aarch64 and x86_64, regardless of the actual build arch. This allows commands like port bump to function correctly.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 15.0.1 24A348 arm64
Xcode 16.0 16A242d

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

The variant downloads distfiles for both aarch64 and x86_64 arches
regardless of the current build_arch. This allows commands such as port
bump to work for all distfiles.
@macportsbot
Copy link

Notifying maintainers:
@judaew for port dbeaver-community.

Copy link
Contributor

@reneeotten reneeotten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JLindop there is no need for that variant - please remove. You can update the checksums yourself without the convenience of "port bump".

@JLindop
Copy link
Contributor Author

JLindop commented Oct 26, 2024

I added the variant after a conversation I had with jmr on IRC a few weeks ago:

[17:25:09] <JLindop> Is there a way to override the build_arch that MacPorts uses? I'm trying to use port bump, but it only updates the checksums for the arm64 arch.
[18:05:56] <jmr> if you have different distfiles for different archs, you should add a variant that downloads them all
[18:06:06] <jmr> both for this and so mirroring works properly

Perhaps I misinterpreted what he meant, though?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants