Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coverage.yml and main.yml: silence actionlint warnings #341

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

coverage.yml and main.yml: silence actionlint warnings #341

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c489fa7
[coverage|main].yml: silence actionlint warnings
cooljeanius Jul 6, 2024
bfb6cd8
disable certain shellcheck warnings
cooljeanius Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,23 +32,23 @@ jobs:
- name: Build MacPorts Base
run: |
set -eu
make -j$(sysctl -n hw.activecpu)
make -j"$(sysctl -n hw.activecpu)"
cooljeanius marked this conversation as resolved.
Show resolved Hide resolved
- name: Install MacPorts Base
run: |
set -eu
sudo make install
- name: Test MacPorts Base
run: |
set -eu
LLVM_PROFILE_FILE="$PWD/cov-%p.profraw" make test
LLVM_PROFILE_FILE="${PWD}/cov-%p.profraw" make test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need to add braces here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it helps me grok more easily where exactly the variable begins and ends

- name: Report Coverage
run: |
set -eu
xcrun llvm-profdata merge --sparse --output=cov.profdata cov-*.profraw
# tracelib cannot be profiled
OBJ_FILES="$(find src -type f "(" -name "*.dylib" -o -name "*.a" ")" | grep -Fv darwintracelib1.0 | sed 's/^/--arch=arm64 --object=/')"
xcrun llvm-cov show --format=html --output-dir=covreport --ignore-filename-regex=vendor/ --instr-profile=cov.profdata $OBJ_FILES
xcrun llvm-cov report --ignore-filename-regex=vendor/ --instr-profile=cov.profdata $OBJ_FILES
xcrun llvm-cov show --format=html --output-dir=covreport --ignore-filename-regex=vendor/ --instr-profile=cov.profdata "${OBJ_FILES}"
xcrun llvm-cov report --ignore-filename-regex=vendor/ --instr-profile=cov.profdata "${OBJ_FILES}"
cooljeanius marked this conversation as resolved.
Show resolved Hide resolved
- name: Archive code coverage results
uses: actions/upload-artifact@v4
with:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- name: Select Xcode version
if: startsWith(matrix.os,'macos')
run: |
case "`uname -r`" in
case "$(uname -r)" in
22.*) sudo xcode-select --switch /Applications/Xcode_14.3.1.app/Contents/Developer
;;
23.*) sudo xcode-select --switch /Applications/Xcode_15.3.app/Contents/Developer
Expand All @@ -47,9 +47,9 @@ jobs:
set -eu
platform=$(uname -s)
case ${platform} in
Darwin) make -j$(sysctl -n hw.activecpu)
Darwin) make -j"$(sysctl -n hw.activecpu)"
cooljeanius marked this conversation as resolved.
Show resolved Hide resolved
;;
Linux) make -j$(nproc)
Linux) make -j"$(nproc)"
cooljeanius marked this conversation as resolved.
Show resolved Hide resolved
;;
esac
- name: Install MacPorts Base
Expand Down