Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use Go 1.22 only Unix-like OSes builds #983

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use Go 1.22 only Unix-like OSes builds #983

wants to merge 1 commit into from

Conversation

lufia
Copy link
Member

@lufia lufia commented Mar 7, 2024

  • upgrade Go version to 1.22.x
  • split out build steps as a reusable workflow from go.yml

ne-sachirou
ne-sachirou reviewed Mar 8, 2024
View reviewed changes
.github/workflows/go-build.yml
inputs:
os-version:
description: 'GitHub-hosted runnners'
default: ubuntu-22.04
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want the default value to be well without maintenance than parameters passed from outside, I want it to be stable. I think ubuntu-latest is more stable than ubuntu-22.04.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ne-sachirou ne-sachirou ne-sachirou left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lufia @ne-sachirou