Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: lint and test workflows #973

Merged
merged 6 commits into from
Mar 6, 2024
Merged

refactor: lint and test workflows #973

merged 6 commits into from
Mar 6, 2024

Commits on Feb 26, 2024

  1. lint action: split away from test actions

    @lufia
    lufia committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    aff445b View commit details
    Browse the repository at this point in the history

  2. check convention: split away from test-linux action

    @lufia
    lufia committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    eb0ed88 View commit details
    Browse the repository at this point in the history

  3. test-linux and test-windows are merged into the test job

    @lufia
    lufia committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    3d1d1b0 View commit details
    Browse the repository at this point in the history

  4. ci: fix failure on macos runners 

    For instance, `echo xx"$(wc -l </dev/null)"xx` outputs
* on linux runners: xx0xx
* on macos runners: xx        0xx

Therefore we shouldn't compare output of `wc -l` to 0 by string equal operator(=).
    @lufia
    lufia committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    88a3a9e View commit details
    Browse the repository at this point in the history

  5. ci: use LF line ending always in the case of *.go files 

    gofmt formats all CRLF to LF in *.go files.
it results failure of convention job on GitHub Actions,
especially on windows host runners.
    @lufia
    lufia committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    15310ca View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. ci: enables gofmt linter of golangci

    @lufia
    lufia committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    b154eea View commit details
    Browse the repository at this point in the history