Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid iowait percentage's overflow when counter is reset #947

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Avoid iowait percentage's overflow when counter is reset #947

merged 2 commits into from
Nov 17, 2023

Conversation

Arthur1
Copy link
Member

@Arthur1 Arthur1 commented Nov 16, 2023 •
edited
Loading

IOwait counter retrieved from /proc/stat can be reset.

I noticed that the "iowait" mode was also the only mode which had any counter resets.
prometheus/prometheus#2856 (comment)

I created a function to calculate the difference of counters considering resets to avoid overflows.

@Arthur1 Arthur1 self-assigned this Nov 16, 2023
ne-sachirou
ne-sachirou approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@ne-sachirou ne-sachirou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙆‍♀️

@Arthur1 Arthur1 merged commit e6ac1b6 into master Nov 17, 2023
6 checks passed
@Arthur1 Arthur1 deleted the iowait-can-be-reset branch November 17, 2023 07:09
@mackerelbot mackerelbot mentioned this pull request Dec 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ne-sachirou ne-sachirou ne-sachirou approved these changes

Assignees

@Arthur1 Arthur1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arthur1 @ne-sachirou