Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a distance method to the Glove class #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions glove/glove.py
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,37 @@ def most_similar(self, word, number=5):

return self._similarity_query(self.word_vectors[word_idx], number)[1:]

def _similarity(self, word1_vec, word2_vec):
dst = (np.dot(word1_vec, word2_vec)
/ np.linalg.norm(word1_vec)
/ np.linalg.norm(word2_vec))

return dst

def similarity(self, word1, word2):
"""
Return the similarity measure between word1 and word2.
"""

if self.word_vectors is None:
raise Exception('Model must be fit before querying')

if self.dictionary is None:
raise Exception('No word dictionary supplied')

try:
word1_idx = self.dictionary[word1]
except KeyError:
raise Exception('Word not in dictionary')

try:
word2_idx = self.dictionary[word2]
except KeyError:
raise Exception('Word not in dictionary')

return self._distance(self.word_vectors[word1_idx],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this actually work? Maybe a leftover from the previous version?

Copy link

@enfageorge enfageorge Aug 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@owo _distance is not defined in the current version anyway. I tried running the code with the added functions _similarity and similarity but ended up with
AttributeError: 'Glove' object has no attribute '_distance'

self.word_vectors[word2_idx])

def most_similar_paragraph(self, paragraph, number=5, **kwargs):
"""
Return words most similar to a given paragraph (iterable of tokens).
Expand Down