Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slack to fgtable interpolation #5

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

etotheipluspi
Copy link

@etotheipluspi etotheipluspi commented Sep 17, 2024

Factor can move out of bounds when we do wind calculations (some numerical stuff upstream of this). Adding epsilon helps solve the issue here.

Fixes this issue at low initial speeds and high winds:

Assertion failed: (Factor >= 0.0 && Factor <= 1.0), function GetValue, file FGTable.cpp, line 512.

Tested with wind sims locally and able to reproduce same results without any of the previous assertion triggered crashes coming from the Factor being out of bounds.

Copy link

@mhand1998 mhand1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick otherwise LGTM

@etotheipluspi etotheipluspi merged commit 525fe6a into master Sep 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants