Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Migrate Modules to TypeScript #951

Merged
merged 5 commits into from
Feb 3, 2025

Conversation

alexs-mparticle
Copy link
Collaborator

@alexs-mparticle alexs-mparticle commented Nov 21, 2024

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Collects TypeScript Migration commits for testing and validation.

Testing Plan

  • Was this tested locally? If not, explain why.
  • {explain how this has been tested, and what, if any, additional testing should be done}

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@alexs-mparticle alexs-mparticle changed the base branch from master to development November 21, 2024 21:11
@alexs-mparticle alexs-mparticle marked this pull request as ready for review November 21, 2024 21:45
@alexs-mparticle alexs-mparticle added the refactor Changes to the structure of the code label Nov 25, 2024
@rmi22186 rmi22186 force-pushed the refactor/ts-migration-blackout-2024 branch from bd9a63d to c66ec58 Compare December 18, 2024 20:49
@alexs-mparticle alexs-mparticle force-pushed the refactor/ts-migration-blackout-2024 branch from b28c45d to 29f34b0 Compare January 21, 2025 15:04
@alexs-mparticle alexs-mparticle force-pushed the refactor/ts-migration-blackout-2024 branch from 29f34b0 to 78a0cb2 Compare January 21, 2025 17:13
@alexs-mparticle alexs-mparticle force-pushed the refactor/ts-migration-blackout-2024 branch from 78a0cb2 to c9a2723 Compare January 27, 2025 15:23
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
11.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@alexs-mparticle alexs-mparticle merged commit 79b1840 into development Feb 3, 2025
21 of 29 checks passed
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 2.32.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Changes to the structure of the code released wait to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants