Add Arabic Translation ! #925
Conversation
|
|
|
Bruh this is a meme translation.
This is Egyptian not Arabic. |
|
@jermanuts thanks for reviewing my work, I'm a native speaker with Egyptian accent Lines mentioned were intentionally wrote in Egyptian accent, As i thought it would be more clear explaining/Getting user attention in important warnings, I tested it with real people around and it was fine I'm happy to edit these if you think it would interrupt with the user understanding of important stages of the wallet |
Sure. |
|
@jermanuts would be awesome if you reviewed again, i fixed some lines Thanks. |
|
@Justxd22 Add spacing, you removed spaces between lines, see the original https://github.com/m2049r/xmrwallet/blob/master/app/src/main/res/values/strings.xml
معرّف do all
مونيروجو Like in the original string
ألصق
العقد، على طريقتك Translate Tor to تور , Monero to مونيرو and Monerujo to مونيروجو be consistent Also you didn't change the about.xml file, monerujo is transliterated to مونيروجو only once then monerujo is used instead of the transliteration. @m2049r Can we transliterate monerujo? because it breaks RTL when used at the beginning of any sentences like |
|
@jermanuts Big thanks for reviewing ! |
|
ال/حافظة -> ال/محفظة رمز الاستجابة السريعة -> رمز QR |
|
@jermanuts thanks! note other "حافظة are referring to clipboard |
ah, ok 😄 |
@anhdres please review this - esp. the comment above |
|
I'd transliterate Monerujo, specially if it improves the way a user may refer to it verbally, because transliterating it should preserve that. If it were only for the left vs right layout I'd just add a word in Arabic before Monerujo (that makes sense, of course) and solve it that way. @m2049r The only use case where literal Monerujo needs to be preserved (I'm guessing) is in the legal text, because I assume it should match perfectly with the name of the app. According to Google, seems like a fair transliteration: |
|
Yep, like Monero, the transliteration for it in Arabic is more popular, also with Tor. مونيرو and تور. |
|
@Justxd22 lets translate all instances of Monerujo to مونيروجو except the legal stuff, append the original name and the Arabic transliteration afterwards to preserve RTL. Like: مونيروجو (Monerujo) ................................................ |
Perfect, do it the way you need (left or right) so that it doesn't break the layout again. You can put (Monerujo) between brackets for example. |
|
|
Ready for merge Note: there was changes in EN locale to fix some typos. 90a0654 |
|
That's a correction? Is Monerujo an extended name for Moneroj? My understand was that Moneroj was the plural for Monero, as like, the coin. |
|
@lucasmz-dev no idea it's my first time i see "moneroj" i thought it's a typo? Should i drop it? |
|
I'm not sure, to be honest. I'd search more on it... When I posted the last comment I thought you were the owner of the repo for some reason (?) On English Wikipedia, I see it being described as that, if you can find any docs from like, getmonero.org saying similar or at least using that word in that context, I'd keep it that way. |
|
Haha nah I'm just a contributor, maybe @m2049r can confirm this? |
|
@anhdres can you please review this 🙏 |
|
moneroj is the plural for monero, but I think you can change it to moneros or the equivalent in your language if you think it helps with understanding. monerujo supposedly means wallet in Esperanto. |
|
@anhdres can you check this Justxd22@90a0654 |
|
I should read moneroj and not Moneroj, but definitely not Monerujo. It's talking about the coins, not the app. |
Dropped 90a0654 and changed to "moneroj" as anhdres comment.
|
@anhdres done, Ready for merge! |
|
Would you like me to import this into Weblate? #966 |
|
@lucasmz-dev yes please, but i need this merged first so it counts as contribution |
|
DW, you get credits in Git with Weblate |
|
@lucasmz-dev shouldn't this pr be merged to the codebase ? so you can pull the translations on weblate |
|
No, I can do this without that, though it won't include the changes to the English file (I don't think this is a great PR to do that either) Why exactly do you want it to "count as a contribution"? Do you want GitHub to notice it and allow you to pin it or something on your profile? |
|
[edit] the plural was changed then later anhdres said it was intentional so i dropped it but it looks like i did it in lower case @lucasmz-dev the English file only edits "moneroj" plural, i can drop English if that's what is stopping this PR, Yes i want to be added to the contribution list of this repo and pin it as well to my profile 🙂 (I'm building my GitHub as an SE student) |
|
ok, i'll leave this for you to manage then |
|
@lucasmz-dev can we just merge already? This translation was bounty https://bounties.monero.social/posts/100/1-100m-arabic-language-in-monerujo-wallet. I'm sorry but I don't see why we should postpone it longer than it have been already (almost a year). @Justxd22 Why a translation contribution would be any relevant to your Github profile as "SE student"? |
|
@lucasmz-dev dropped English, @m2049r ready for merge |
Translated and Added:
By following the translation guide, Tested and ready for merge!