Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bios: added debug info about flashboot source #89

Closed
wants to merge 1 commit into from

Conversation

danielkucera
Copy link
Contributor

No description provided.

@sbourdeauducq
Copy link
Member

OK, but what do you need this for?

@danielkucera
Copy link
Contributor Author

I was playing with gateware and modifying flash_boot_address but then I realized that the change is not propagated into bios because it was compiled few weeks ago and not recompiling after gateware change. So I added this to see where does bios try to load the firmware from to avoid similar problems and complicated debugging in the future.

@sbourdeauducq
Copy link
Member

the change is not propagated into bios because it was compiled few weeks ago and not recompiling after gateware change.

Is that because you didn't reflash it, or because there is a problem with the build system?

@danielkucera
Copy link
Contributor Author

I'm building the flash file on my own from top.bin and bios.bin and if I don't do rm build/software/bios/*, bios is not rebuilt automatically

@sbourdeauducq
Copy link
Member

sbourdeauducq commented Jul 29, 2018

Then it is a problem with the build system? In that case it should be fixed instead. This problem can pop up in other (and worse) ways otherwise, e.g. if you change the addresses of the CSRs used by the BIOS for everything (UART etc.).

@danielkucera
Copy link
Contributor Author

probably yes. I'm not denying there is another problem but I think this patch has it's added value and is worth accepting. If you don't agree I have no problem if you refuse it.

@sbourdeauducq
Copy link
Member

It's generally better to go for the root cause of the problems than accumulate a pile of ad-hoc incomplete solutions.

@danielkucera
Copy link
Contributor Author

for the main problem see issue #91

@sbourdeauducq
Copy link
Member

OK, then let's fix #91.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants