Merge pull request numpy#24273 from BvB93/overload

TYP: Trim down the `_NestedSequence.__getitem__` signature
lysnikolaou · Jul 31, 2023 · 8bbfa6d · 8bbfa6d
2 parents 7b2dfba + 1ba826a
commit 8bbfa6d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/numpy/_typing/_nested_sequence.py b/numpy/_typing/_nested_sequence.py
@@ -5,7 +5,6 @@
 from collections.abc import Iterator
 from typing import (
     Any,
-    overload,
     TypeVar,
     Protocol,
     runtime_checkable,
@@ -62,12 +61,7 @@ def __len__(self, /) -> int:
         """Implement ``len(self)``."""
         raise NotImplementedError
 
-    @overload
-    def __getitem__(self, index: int, /) -> _T_co | _NestedSequence[_T_co]: ...
-    @overload
-    def __getitem__(self, index: slice, /) -> _NestedSequence[_T_co]: ...
-
-    def __getitem__(self, index, /):
+    def __getitem__(self, index: int, /) -> _T_co | _NestedSequence[_T_co]:
         """Implement ``self[x]``."""
         raise NotImplementedError
 

diff --git a/numpy/typing/tests/data/reveal/array_constructors.pyi b/numpy/typing/tests/data/reveal/array_constructors.pyi
@@ -1,5 +1,6 @@
 from typing import Any, TypeVar
 from pathlib import Path
+from collections import deque
 
 import numpy as np
 import numpy.typing as npt
@@ -26,6 +27,7 @@ reveal_type(np.array(A))  # E: ndarray[Any, dtype[{float64}]]
 reveal_type(np.array(B))  # E: ndarray[Any, dtype[{float64}]]
 reveal_type(np.array(B, subok=True))  # E: SubClass[{float64}]
 reveal_type(np.array([1, 1.0]))  # E: ndarray[Any, dtype[Any]]
+reveal_type(np.array(deque([1, 2, 3])))  # E: ndarray[Any, dtype[Any]]
 reveal_type(np.array(A, dtype=np.int64))  # E: ndarray[Any, dtype[{int64}]]
 reveal_type(np.array(A, dtype='c16'))  # E: ndarray[Any, dtype[Any]]
 reveal_type(np.array(A, like=A))  # E: ndarray[Any, dtype[{float64}]]