Prefer max CPU frequency from /sys over DMI info #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the first module to set the max CPU frequency (capacity) is `dmi`. The `cpufreq` module only overwrites this value if it determined a value greater than the one from DMI. However, as the dmidecode man page [1] states: > More often than not, information contained in the DMI tables is > inaccurate, incomplete or simply wrong. [1] https://linux.die.net/man/8/dmidecode I can attest to that, insofar as many of the servers I manage report a hugely exaggerated max frequency in the DMI data, whereas the sysfs data from the `cpufreq` module is always correct. With the current approach of only overwriting the value if it is greater than the one from DMI, these exaggerated values show up in the final output of `lshw`. This commit always prefers the max CPU frequency value from the `cpufreq` module, unless it is `0` (i.e. failed to determine). Signed-off-by: Conrad Hoffmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the first module to set the max CPU frequency (capacity) is
dmi. Thecpufreqmodule only overwrites this value if it determined a value greater than the one from DMI.However, as the dmidecode man page [1] states:
[1] https://linux.die.net/man/8/dmidecode
I can attest to that, insofar as many of the servers I manage report a hugely exaggerated max frequency in the DMI data, whereas the sysfs data from the
cpufreqmodule is always correct.With the current approach of only overwriting the value if it is greater than the one from DMI, these exaggerated values show up in the final output of
lshw.This commit always prefers the max CPU frequency value from the
cpufreqmodule, unless it is0(i.e. failed to determine).