Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Keycloak 17+ (parameterized the endpoint /auth ) #79

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

psavva
Copy link

@psavva psavva commented Aug 2, 2022

Upgraded to net-6.0
Upgraded Flur Library
Removed compatibility for .net classic
Removed compatibility for .net standard 1.x

Upgraded to net-6.0
Upgraded Flur Library
Removed compatibility for .net classic
Removed compatibility for .net standard 1.x
@psavva
Copy link
Author

psavva commented Aug 2, 2022

@lvermeulen Please review.

@pocketken
Copy link

@psavva technically, the prefix is actually configurable. It no longer defaults to /auth, but, administrators are still free to configure it with whatever prefix they want when reverse proxying -- we add /auth back in our environment, for example.

Maybe it'd be handy for it to be configurable here too?

@psavva
Copy link
Author

psavva commented Aug 31, 2022

@pocketken fair point, I'll update the PR accordingly

@akloster
Copy link

@psavva is there a nuget package I could install which can vary the "auth" path?

This repository hasn't been updated since May 2021.

@psavva
Copy link
Author

psavva commented Sep 14, 2022

Not yet

@mesutpiskin
Copy link

I think this pr should be marge

@psavva
Copy link
Author

psavva commented Sep 23, 2022

I have updated the PR to include the path.

You can now do something like this:
No path (ie: Keycloak 17+): new KeycloakClient(url: url, userName: userName, password: password, prefix:null);
With Path (ie Keycloak 16-): new KeycloakClient(url: url, userName: userName, password: password, prefix:"auth");

@psavva
Copy link
Author

psavva commented Sep 23, 2022

@lvermeulen Please see if you can review, and bring this one in..
I think it will help a lot of people :)

Thank you for the awesome work on this project

@psavva psavva changed the title Upgrade Keycloak 17+ (Removed /auth ) Upgrade Keycloak 17+ (parameterized the endpoint /auth ) Oct 10, 2022
@digitalddq
Copy link

digitalddq commented Nov 5, 2022

@lvermeulen can this PR please be merged?
With kubernetes operator (v19) based deployments, I don't see any way to adjust the endpoint name, it is a blocker in this case.

Using KC 19 we have adjusted the code and built our private NuGets as a workaround. I would really appreciate it, if it's solved in the main repo.

@CesarD
Copy link

CesarD commented Jul 14, 2023

What is required to finally merge this PR? It's a blocker for me as well and I'm sure for many other people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants