Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update some vignettes (Wikidata & other triplestores, complex queries) #157

Merged
merged 44 commits into from
Sep 28, 2023

Conversation

lvaudor
Copy link
Owner

@lvaudor lvaudor commented Aug 30, 2023

Fix #92

@lvaudor lvaudor changed the title update Wikidata vignette update some vignettes (Wikidata & other triplestores, complex queries) Aug 30, 2023
@lvaudor lvaudor requested a review from maelle September 15, 2023 11:18
@lvaudor
Copy link
Owner Author

lvaudor commented Sep 15, 2023

I have been taking my time on this PR and actually will try and merge it before I have completed everything I wanted (so actually I just worked on the Wikidata vignette (or is an article also?) and the "glitter for bibliometry" (which should in the end replace the "glitter for hal" article. The thing is, I'm not sure how to make these changes work with those you implemented on the "refactor" PR @maelle. In which order should we do this?

@lvaudor lvaudor marked this pull request as ready for review September 15, 2023 14:29
@maelle
Copy link
Collaborator

maelle commented Sep 21, 2023

@lvaudor I fetched this PR locally and could see that the spq_control_request() function was here so all good, you're working on an up-to-date branch!

DESCRIPTION Outdated Show resolved Hide resolved
Copy link
Collaborator

@maelle maelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on the first article, I'll read wikidata now

DESCRIPTION Outdated Show resolved Hide resolved
vignettes/articles/explore.Rmd Outdated Show resolved Hide resolved
vignettes/articles/explore.Rmd Outdated Show resolved Hide resolved
vignettes/articles/explore.Rmd Outdated Show resolved Hide resolved
vignettes/articles/explore.Rmd Outdated Show resolved Hide resolved
vignettes/articles/glitter_bibliometry.Rmd Outdated Show resolved Hide resolved
vignettes/articles/glitter_bibliometry.Rmd Outdated Show resolved Hide resolved
vignettes/articles/glitter_bibliometry.Rmd Outdated Show resolved Hide resolved
vignettes/articles/glitter_bibliometry.Rmd Outdated Show resolved Hide resolved
vignettes/articles/glitter_bibliometry.Rmd Show resolved Hide resolved
Copy link
Collaborator

@maelle maelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice wikidata vignette! it could get "spatial" in the title I think!

vignettes/articles/glitter_for_Wikidata.Rmd Outdated Show resolved Hide resolved
vignettes/articles/glitter_for_Wikidata.Rmd Outdated Show resolved Hide resolved
vignettes/articles/glitter_for_Wikidata.Rmd Show resolved Hide resolved
vignettes/articles/glitter_for_Wikidata.Rmd Outdated Show resolved Hide resolved
vignettes/articles/glitter_for_Wikidata.Rmd Outdated Show resolved Hide resolved
vignettes/articles/glitter_for_Wikidata.Rmd Outdated Show resolved Hide resolved
vignettes/articles/glitter_for_Wikidata.Rmd Show resolved Hide resolved
@maelle maelle merged commit be779dc into main Sep 28, 2023
7 checks passed
@maelle maelle deleted the dokeydoc branch September 28, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Besoin de mettre à jour la vignette "glitter for Wikidata"
2 participants