Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stricter Config Types #60

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Stricter Config Types #60

merged 1 commit into from
Aug 19, 2024

Conversation

kozlov721
Copy link
Collaborator

Changed types in luxonis_train.utils.config.Config to be stricter and not allow invalid values to be used.

@kozlov721 kozlov721 self-assigned this Aug 19, 2024
klemen1999
klemen1999 approved these changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@klemen1999 klemen1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left some comments

luxonis_train/utils/config.py Show resolved Hide resolved
luxonis_train/utils/config.py Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Test Results

  3 files    3 suites   31m 20s ⏱️
 51 tests  49 ✅ 0 💤 2 ❌
132 runs  128 ✅ 1 💤 3 ❌

For more details on these failures, see this check.

Results for commit f00a9b4.

@kozlov721 kozlov721 merged commit 55df6ef into dev Aug 19, 2024
3 of 8 checks passed
@kozlov721 kozlov721 deleted the fix/config-types branch August 19, 2024 15:15
kozlov721 added a commit that referenced this pull request Oct 9, 2024
@kozlov721
Stricter Config Types (#60)
4a34f76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klemen1999 klemen1999 klemen1999 approved these changes

@tersekmatija tersekmatija Awaiting requested review from tersekmatija

@conorsim conorsim Awaiting requested review from conorsim

Assignees

@kozlov721 kozlov721

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kozlov721 @klemen1999