Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for LuxonisML - Annotation Refactor #37

Merged
merged 5 commits into from
Jun 6, 2024
Merged

Conversation

kozlov721
Copy link
Collaborator

  • Support for refactored annotations in LuxonisML (110)
    • Option to specify task field under node's config
    • The specified task is used by the node and all the attached modules
  • Test case for multi-task model

@kozlov721 kozlov721 added the enhancement New feature or request label Jun 2, 2024
@kozlov721 kozlov721 self-assigned this Jun 2, 2024
Copy link

github-actions bot commented Jun 2, 2024

Test Results

  6 files    6 suites   2m 8s ⏱️
 58 tests  25 ✅  25 💤 0 ❌  8 🔥
348 runs  150 ✅ 150 💤 0 ❌ 48 🔥

For more details on these errors, see this check.

Results for commit dcac9d9.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@conorsim conorsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM - not sure if the ubuntu tests need to be updated though

@kozlov721
Copy link
Collaborator Author

not sure if the ubuntu tests need to be updated though

they are using the dev branch of luxonis-ml which doesn't yet have the new annotations merged. I'll re-run the tests when it gets merged.

Copy link

github-actions bot commented Jun 6, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
4846 3712 77% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
luxonis_train/main.py 49% 🟢
luxonis_train/attached_modules/base_attached_module.py 82% 🟢
luxonis_train/attached_modules/losses/adaptive_detection_loss.py 98% 🟢
luxonis_train/attached_modules/losses/implicit_keypoint_bbox_loss.py 97% 🟢
luxonis_train/attached_modules/losses/keypoint_loss.py 97% 🟢
luxonis_train/attached_modules/metrics/common.py 93% 🟢
luxonis_train/attached_modules/metrics/mean_average_precision.py 100% 🟢
luxonis_train/attached_modules/metrics/mean_average_precision_keypoints.py 94% 🟢
luxonis_train/attached_modules/metrics/object_keypoint_similarity.py 95% 🟢
luxonis_train/attached_modules/visualizers/keypoint_visualizer.py 100% 🟢
luxonis_train/attached_modules/visualizers/segmentation_visualizer.py 81% 🟢
luxonis_train/core/archiver.py 19% 🟢
luxonis_train/core/core.py 78% 🟢
luxonis_train/models/luxonis_model.py 89% 🟢
luxonis_train/nodes/base_node.py 76% 🟢
luxonis_train/nodes/bisenet_head.py 50% 🟢
luxonis_train/nodes/classification_head.py 100% 🟢
luxonis_train/nodes/efficient_bbox_head.py 100% 🟢
luxonis_train/nodes/implicit_keypoint_bbox_head.py 92% 🟢
luxonis_train/nodes/segmentation_head.py 100% 🟢
luxonis_train/utils/boxutils.py 83% 🟢
luxonis_train/utils/config.py 95% 🟢
luxonis_train/utils/general.py 78% 🟢
luxonis_train/utils/loaders/base_loader.py 72% 🟢
luxonis_train/utils/loaders/luxonis_loader_torch.py 100% 🟢
luxonis_train/utils/types.py 91% 🟢
TOTAL 85% 🟢

updated for commit: dcac9d9 by action🐍

@kozlov721 kozlov721 merged commit c2e98b7 into dev Jun 6, 2024
@kozlov721 kozlov721 deleted the feature/simple-labels branch June 6, 2024 19:35
kozlov721 added a commit that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants