Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added active param to augmentations #32

Merged
merged 1 commit into from
May 24, 2024
Merged

Added active param to augmentations #32

merged 1 commit into from
May 24, 2024

Conversation

klemen1999
Copy link
Collaborator

  • Added active parameter for each augmentation
  • Augmentation gets only currently active augmentations
  • This makes it possible for Tuner to turn on/off specific augmentation per trial. Example part of config:
trainer:
  ...
  preprocessing:
    ...
     augmentations:
       - name: Defocus
         params:
           p: 0.1
tuner:
  params:
    trainer.preprocessing.augmentations.0.active_categorical: [True, False]

@klemen1999
Copy link
Collaborator Author

Nice future improvement would be to make _subset keyword for Tuner (e.g. trainer.preprocessing.augmentations: [["Defocus", "Sharpen", "RandomRotate90"], 2] - would make subset of size 2 from the list) but we would have to think how to make it general enough. If we make it for augmentations only this would mean just turning off active parameter for all unselected augs but if for example user tries to use it on parameter that doesn't have this active flag it would fail. Essentially the question is how general do we want to make this "_subset" tunning.

@kozlov721 kozlov721 added the enhancement New feature or request label May 22, 2024
Copy link
Collaborator

@kozlov721 kozlov721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
4717 3654 77% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
luxonis_train/main.py 49% 🟢
luxonis_train/core/core.py 78% 🟢
luxonis_train/utils/config.py 95% 🟢
TOTAL 74% 🟢

updated for commit: 8c06a77 by action🐍

Copy link

Test Results

  6 files    6 suites   38m 40s ⏱️
 57 tests  25 ✅  25 💤  7 ❌
342 runs  177 ✅ 150 💤 15 ❌

For more details on these failures, see this check.

Results for commit 8c06a77.

@kozlov721 kozlov721 merged commit 4110f78 into dev May 24, 2024
5 of 10 checks passed
@kozlov721 kozlov721 deleted the feature/aug_active branch May 24, 2024 16:34
kozlov721 pushed a commit that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants