Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gradient visualization during validation #115

Merged
merged 6 commits into from
Nov 2, 2024

Conversation

sokovninn
Copy link
Member

This pull request introduces a new callback for visualizing gradients using Grad-CAM during validation in the luxonis_train package. The most important changes include the addition of the GradCamCallback class, updates to the callback registration, and documentation updates.

New Callback Implementation:

Callback Registration:

Documentation:

@sokovninn sokovninn requested a review from a team as a code owner October 17, 2024 22:24
@sokovninn sokovninn requested review from kozlov721, klemen1999, tersekmatija and conorsim and removed request for a team October 17, 2024 22:24
@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 17, 2024
Copy link
Collaborator

@klemen1999 klemen1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, left some comments

luxonis_train/callbacks/README.md Show resolved Hide resolved
luxonis_train/callbacks/README.md Show resolved Hide resolved
requirements.txt Show resolved Hide resolved
luxonis_train/callbacks/gradcam_visializer.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@kozlov721 kozlov721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 42 lines in your changes missing coverage. Please review.

Project coverage is 96.31%. Comparing base (6146da6) to head (3de20bf).
Report is 8 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
luxonis_train/callbacks/gradcam_visializer.py 31.14% 42 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
- Coverage   97.12%   96.31%   -0.81%     
==========================================
  Files         139      147       +8     
  Lines        6012     6304     +292     
==========================================
+ Hits         5839     6072     +233     
- Misses        173      232      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sokovninn sokovninn merged commit 45fccdc into main Nov 2, 2024
7 of 9 checks passed
@sokovninn sokovninn deleted the feat/gradient-visualization branch November 2, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants