Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better parallel implementation for RVC4 NeuralNetwork node #1220

Merged
merged 8 commits into from
Jan 24, 2025
Merged

Better parallel implementation for RVC4 NeuralNetwork node #1220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7f6ddc9
Bump RVC4 FW
Jan 23, 2025
fac7d02
Bump the upload artifact action to v4
Jan 23, 2025
e9e9f2d
Bump download-artifact to v4
Jan 23, 2025
8277a92
Avoid uploading the whole audited dir
Jan 24, 2025
c9edd91
Merge remote-tracking branch 'origin/v3_develop' into v3_parallel_nn_…
Jan 24, 2025
a6a3fd1
Update download and upload action
Jan 24, 2025
11a444d
Merge remote-tracking branch 'origin/v3_develop' into v3_parallel_nn_…
Jan 24, 2025
4bcad19
Further specify the Mac name
Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 23 additions & 22 deletions .github/workflows/python-main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
- name: Build target 'pybind11_mkdoc'
run: cmake --build build --target pybind11_mkdoc --parallel 4
- name: Upload docstring artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: docstrings
path: bindings/python/docstrings/
Expand Down Expand Up @@ -103,7 +103,7 @@ jobs:
with:
submodules: 'recursive'

- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: 'docstrings'
path: bindings/python/docstrings
Expand Down Expand Up @@ -159,7 +159,7 @@ jobs:
# with:
# submodules: 'recursive'

# - uses: actions/download-artifact@v3
# - uses: actions/download-artifact@v4
# with:
# name: 'docstrings'
# path: bindings/python/docstrings
Expand Down Expand Up @@ -224,7 +224,7 @@ jobs:
core.exportVariable('ACTIONS_CACHE_URL', process.env.ACTIONS_CACHE_URL || '');
core.exportVariable('ACTIONS_RUNTIME_TOKEN', process.env.ACTIONS_RUNTIME_TOKEN || '');

- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: 'docstrings'
path: bindings/python/docstrings
Expand All @@ -248,10 +248,10 @@ jobs:
- name: Building wheels
run: cd bindings/python && python -m pip wheel . -w ./wheelhouse/audited/ --verbose
- name: Archive wheel artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: audited-wheels
path: bindings/python/wheelhouse/audited/
name: audited-wheels-windows-${{ matrix.python-version }}
path: bindings/python/wheelhouse/audited/*
- name: Deploy wheels to artifactory (if not a release)
if: startsWith(github.ref, 'refs/tags/v') != true
run: cd bindings/python && bash ./ci/upload-artifactory.sh
Expand Down Expand Up @@ -295,7 +295,7 @@ jobs:
with:
submodules: 'recursive'

- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: 'docstrings'
path: bindings/python/docstrings
Expand All @@ -320,10 +320,10 @@ jobs:
- name: Auditing wheels
run: cd bindings/python && ci/repair-whl-macos.sh `pwd`/wheelhouse/* `pwd`/wheelhouse/audited
- name: Archive wheel artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: audited-wheels
path: bindings/python/wheelhouse/audited/
name: audited-wheels-macos-${{ matrix.os }}-${{ matrix.python-version }}
path: bindings/python/wheelhouse/audited/*
- name: Deploy wheels to artifactory (if not a release)
if: startsWith(github.ref, 'refs/tags/v') != true
run: cd bindings/python && bash ./ci/upload-artifactory.sh
Expand Down Expand Up @@ -356,7 +356,7 @@ jobs:
# run: |
# brew install opencv

# - uses: actions/download-artifact@v3
# - uses: actions/download-artifact@v4
# with:
# name: 'docstrings'
# path: bindings/python/docstrings
Expand Down Expand Up @@ -436,7 +436,7 @@ jobs:
- name: Create folder structure
run: cd bindings/python && mkdir -p wheelhouse/audited/

- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: 'docstrings'
path: bindings/python/docstrings
Expand All @@ -459,10 +459,10 @@ jobs:
- name: Audit wheels
run: cd bindings/python && for whl in wheelhouse/*.whl; do auditwheel repair "$whl" --plat $PLAT -w wheelhouse/audited/; done
- name: Archive wheel artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: audited-wheels
path: bindings/python/wheelhouse/audited/
name: audited-wheels-linux-x86_64-${{ matrix.python-set }}
path: bindings/python/wheelhouse/audited/*
- name: Deploy wheels to artifactory (if not a release)
if: startsWith(github.ref, 'refs/tags/v') != true
run: cd bindings/python && bash ./ci/upload-artifactory.sh
Expand Down Expand Up @@ -521,7 +521,7 @@ jobs:
- name: Create folder structure
run: cd bindings/python && mkdir -p wheelhouse/audited/

- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: 'docstrings'
path: bindings/python/docstrings
Expand All @@ -537,10 +537,10 @@ jobs:
- name: Auditing wheels
run: cd bindings/python && for whl in wheelhouse/*.whl; do auditwheel repair "$whl" --plat $PLAT -w wheelhouse/audited/; done
- name: Archive wheel artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: audited-wheels
path: bindings/python/wheelhouse/audited/
name: audited-wheels-linux-arm64-${{ matrix.python-set }}
path: bindings/python/wheelhouse/audited/*
- name: Deploy wheels to artifactory (if not a release)
if: startsWith(github.ref, 'refs/tags/v') != true
run: cd bindings/python && bash ./ci/upload-artifactory.sh
Expand Down Expand Up @@ -577,9 +577,10 @@ jobs:
- uses: actions/checkout@v3
with:
submodules: 'recursive'
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: audited-wheels
pattern: audited-wheels*
merge-multiple: true
path: bindings/python/wheelhouse/audited/
- name: List files
run: ls -lah
Expand Down
2 changes: 1 addition & 1 deletion cmake/Depthai/DepthaiDeviceRVC4Config.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ set(DEPTHAI_DEVICE_RVC4_MATURITY "snapshot")

# "version if applicable"
# set(DEPTHAI_DEVICE_RVC4_VERSION "0.0.1+93f7b75a885aa32f44c5e9f53b74470c49d2b1af")
set(DEPTHAI_DEVICE_RVC4_VERSION "0.0.1+fdcf94f7a3eb95715b5a1f54355189ba61ce6bf1")
set(DEPTHAI_DEVICE_RVC4_VERSION "0.0.1+5d1371967432dd4cf1742b56afbf4c669417bcfd")
Loading