Fix number field setter #1970
Open
Fix number field setter #1970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alecritson
reviewed
Sep 30, 2024
Do data type casting from String to either int or float.
ken717w
force-pushed
the
bugfix/number-field-casting
branch
from
d9eadac
to
e94c4f4
Compare
alecritson
previously approved these changes
Sep 30, 2024
|
The tests failed, are there some sort of linting rules? |
Spotted that, pushed a quick patch which should sort it, it was due to |
wychoong
reviewed
Oct 2, 2024
| @@ -54,7 +54,7 @@ public function setValue($value) | |||
| throw new FieldTypeException(self::class.' value must be numeric.'); | |||
| } | |||
|
|
|||
| $this->value = $value; | |||
| $this->value = $value ? $value + 0 : ''; | |||
There was a problem hiding this comment.
does returning '' solve the initial issue?
will setting type hint to property/return/argument solve the issue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do data type casting from String to either int or float.
This should fixes #1969.