Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use requests and upickle instead of zio-json #9

Conversation

KacperFKorban
Copy link

@KacperFKorban KacperFKorban commented Jul 12, 2024

closes #8

@KacperFKorban KacperFKorban marked this pull request as ready for review July 15, 2024 11:42
@Andrapyre
Copy link
Contributor

@KacperFKorban , thanks for the issue/PR and sorry for the delay. If you need this for the sbt-ci-release PR that you linked, this is the wrong repo, as it isn't currently being used by sbt-sonatype. You would need to submit a PR there directly, but I'm still waiting on a comment to clarify the future vision in this thread: xerial/sbt-sonatype#465.

It's a fair point about the transitive dependency. I would handle this slightly differently and use uPickle with sttp (I prefer sttp since it's easier to handle retries in a more granular way. For instance, I don't want to retry if we get an auth error, etc, but that's harder to do with clients that sit on top of requests, since there isn't strong typing around it like there is in sttp). Let me see if I can get a new version of the sonatype-central-client out in a day or so and then it's literally a line or two of changes here.

@KacperFKorban
Copy link
Author

Thanks for the answer. I wasn't sure in which repo to do the change either, so I started here 😅
If you can add a new sttp-upickle module, that would be awesome. I think that most people would prefer lighter dependencies.
I'll close this PR then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove zio-json dependency
2 participants