Support Micronaut 4 ConversionService type #1527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks a lot. I tried to write a test for that here but it's failing. Most likely due to invalid setup on my side. Can you please look at it? |
|
Hi, I am afraid the best way is to create a new micronaut4 module like this. The test pases if I do it this way. |
|
I have created a new module. Feels safer this way. Will be released as 5.8.0 in few minutes. Thanks |
|
Sorry for slow reply. This is amazing! Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Lukáš,
My application uses Micronaut 4, is written in Kotlin, and uses KSP for annotation processing. The annotation SchedulerLock isn't being processed and I believe it's due to SchedulerLockInterceptor's use of ConversionService<?>. ConversionService is unparameterized in Micronaut 4 so I think KSP is quietly failing to apply the interceptor as Aspect advice on my annotated method. This hopefully is backward compatible and will get my code working.