Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files via upload #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add files via upload #14

wants to merge 1 commit into from

Conversation

keesma
Copy link

@keesma keesma commented Mar 7, 2021

Added support for BMP280 (based on BME280)

Added support for BMP280 (based on BME280)
Copy link
Owner

@luebbe luebbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.
One question: Is the BME280 an "extension" of the BMP280? I always thought so, but neve checked, because I don't have a BMP280.
In this case we could inherit the BME280 from the BMP280 (or create a common BMx280 base class) and save a lot of duplicate code.
Do the BME and BMP even share the same I2C addresses?

@keesma
Copy link
Author

keesma commented Mar 9, 2021 via email

@luebbe
Copy link
Owner

luebbe commented Mar 9, 2021

There is a lot that can go into a common base class when I look at the code. I'll let you finish your PR and afterwards I'll refactor.
I'm also thinking about making the sensor nodes more generic. loop() is basically always the same, only taking the measurement differs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants