Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add mention of --with-page #1895

Merged
merged 1 commit into from
Jun 3, 2024
Merged

add mention of --with-page #1895

merged 1 commit into from
Jun 3, 2024

Conversation

snadon
Copy link
Contributor

@snadon snadon commented Jun 3, 2024

Purpose

Improve help message to fix #1873

Description

Add metion of --with-page flag for the gen.action.browser task.

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src

jwoertink
jwoertink approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@jwoertink jwoertink merged commit e069903 into luckyframework:main Jun 3, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwoertink jwoertink jwoertink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gen.action.browser doesn't mention the --with-page flag
2 participants
@snadon @jwoertink