Ensure actions can have early returns #1857
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #1843
Description
This may not actually have been a problem to start and possibly just something weird we had in our app ref; however, I decided to still make this change anyway. By moving the call body in to a separate method, the compile-time error is a lot more accurate. Though, it's not as pretty as before, I think the clarity and accuracy outweighs the custom error message.
Also by adding a few comments above the method, you get a little bit of documentation, and the actual action that's failing which should lead you to a fix a bit quicker.
See #1843 for more info on the error message change
Checklist
crystal tool format spec src
./script/setup
./script/test