optimize route building when there's query params. #1854
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #1831
Description
Crystal 1.10 added a method overload for
HTTP::Params.encode
that takes an IO. This lets us use a single IO to build a route when there's query params.There doesn't seem to really be a difference when there's no query params involved:
But when you use query params, it helps
Using a Crystal version below 1.10.0 will show a deprecation warning
Checklist
crystal tool format spec src
./script/setup
./script/test