Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat make redirect status configurable #1838

Merged

Conversation

wout
Copy link
Contributor

@wout wout commented Oct 18, 2023

Purpose

This PR implements the suggestion in #1837.

Description

It allows the default redirect status (previously hardcoded as 302) to be configured:

Lucky::Redirectable.configure do |config|
  config.redirect_status = 303
end

Checklist

  • - An issue already exists detailing the issue/or feature request that this PR fixes
  • - All specs are formatted with crystal tool format spec src
  • - Inline documentation has been added and/or updated
  • - Lucky builds on docker with ./script/setup
  • - All builds and specs pass on docker with ./script/test

Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@jwoertink jwoertink merged commit dbd2aaf into luckyframework:main Oct 18, 2023
5 checks passed
@wout wout deleted the feat-make-redirect-status-configurable branch October 18, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants