Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Simpler Renderable html macro #1836

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Feat: Simpler Renderable html macro #1836

merged 1 commit into from
Oct 9, 2023

Conversation

mdwagner
Copy link
Contributor

@mdwagner mdwagner commented Oct 9, 2023

Purpose

Instead of invoking a nested macro, we can just use parse_type (Lucky already requires at least 1.6, and parse_type came out in 1.4).

@mdwagner mdwagner self-assigned this Oct 9, 2023
jwoertink
jwoertink approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mdwagner mdwagner merged commit 10752ad into main Oct 9, 2023
5 checks passed
@mdwagner mdwagner deleted the feat/simpler-renderable-macro branch October 9, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwoertink jwoertink jwoertink approved these changes

Assignees

@mdwagner mdwagner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdwagner @jwoertink