Merge pull request #73 from luckyframework/fix/shards-docs

fix: shards for docs

.github/workflows/ci.yml

@@ -24,8 +24,11 @@ jobs:
         run: shards install
       - name: Format
         run: crystal tool format --check
-      - name: Lint
-        run: ./bin/ameba
+      - name: Crystal Ameba Linter
+        id: crystal-ameba
+        uses: crystal-ameba/[email protected]
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
   specs:
     strategy:
       fail-fast: false

README.md

@@ -161,7 +161,7 @@ For more examples on creating a Breeze extension, look at the `BreezeCarbon` ext
 
 ## Development
 
-Install shards `shards install`, and start making changes. Be sure to run `./bin/ameba`, and the crystal formatter `crystal tool format spec src`.
+Install shards `shards install`, and start making changes. Be sure to run [`ameba`](https://github.com/crystal-ameba/ameba), and the crystal formatter `crystal tool format spec src`.
 
 Read through the issues for things you can work on. If you have an idea, feel free to open a new issue!
 

shard.yml

@@ -4,7 +4,7 @@ version: 0.2.0
 authors:
   - Jeremy Woertink <[email protected]>
 
-crystal: ">= 1.4.0"
+crystal: ~> 1.4
 
 license: MIT
 
@@ -18,21 +18,21 @@ scripts:
 dependencies:
   lucky:
     github: luckyframework/lucky
-    version: ">= 1.0.0-rc1"
+    version: ~> 1.0
   avram:
     github: luckyframework/avram
-    version: ">= 1.0.0-rc1"
+    version: ~> 1.0
   pulsar:
     github: luckyframework/pulsar
-    version: ">= 0.2.3"
+    version: ~> 0.2
   lucky_task:
     github: luckyframework/lucky_task
-    version: ">= 0.1.1"
+    version: ~> 0.1
 
 development_dependencies:
-  ameba:
-    github: crystal-ameba/ameba
-    version: "~> 1.1.0"
   lucky_cli:
     github: luckyframework/lucky_cli
-    version: ">= 1.0.0-rc1"
+    version: ~> 1.0
+  carbon:
+    github: luckyframework/carbon
+    version: ~> 0.3

spec/support/with_project_cleanup.cr

@@ -1,5 +1,5 @@
 module WithProjectCleanup
-  private def with_project_cleanup(project_directory = "test-project", skip_db_drop = false)
+  private def with_project_cleanup(project_directory = "test-project", skip_db_drop = false, &)
     yield
 
     FileUtils.cd(project_directory) {

src/breeze/actions/mixins/action_helpers.cr

@@ -72,14 +72,15 @@ module Breeze::ActionHelpers
 
   private def store_breeze_response
     if allow_breeze(context)
-      req = Fiber.current.breeze_request.not_nil!
-      spawn(name: "Create Breeze::SaveBreezeResponse") do
-        Breeze::SaveBreezeResponse.create!(
-          breeze_request_id: req.id,
-          status: response.status_code,
-          session: JSON.parse(session.to_json),
-          headers: JSON.parse(response.headers.to_h.to_json)
-        )
+      if req = Fiber.current.breeze_request
+        spawn(name: "Create Breeze::SaveBreezeResponse") do
+          Breeze::SaveBreezeResponse.create!(
+            breeze_request_id: req.id,
+            status: response.status_code,
+            session: JSON.parse(session.to_json),
+            headers: JSON.parse(response.headers.to_h.to_json)
+          )
+        end
       end
     end
 

src/breeze/components/breeze/panel.cr

@@ -1,5 +1,5 @@
 class Breeze::Panel < Breeze::BreezeComponent
-  def render
+  def render(&)
     div class: "mb-12 bg-white rounded-lg shadow-lg overflow-hidden" do
       yield
     end